search

delba / Permission

A unified API to ask for permissions on iOS
MIT License
2.91k stars 324 forks source link

.Bluetooth patch (master) #76

Closed jakerockland closed 7 years ago

jakerockland commented 7 years ago

This addresses #36 and replaces #74 which was closed due to swift-3.0 being merged to master.

jakerockland commented 7 years ago

It looks to me that this is failing the CI for other reasons that have to do with the current state of master and not actually with the changes in this PR, can you take a look @delba? I'd like to start integrating our project to use the current stable version of the framework rather than our fork but we need Bluetooth permissions to be fully functioning 😄 I believe this is ready to merge.

jakerockland commented 7 years ago

@AndrewSB Hopefully so, found this to resolve the issues I was having. If you're experiencing other weird behaviour that this patch doesn't fix I would be happy to look into it as it may be an edge case we just haven't seen yet but that would effect our application as well 😛

AndrewSB commented 7 years ago

Will let you know, I'm probably going to end up debugging that Wednesday/Thursday this week

On Mon, Nov 7, 2016 at 3:50 PM Jake Rockland notifications@github.com wrote:

@AndrewSB https://github.com/AndrewSB Hopefully so, found this to resolve the issues I was having. If you're experiencing other weird behaviour that this patch doesn't fix I would be happy to look into it as it may be an edge case we just haven't seen yet but that would effect our application as well 😛

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/delba/Permission/pull/76#issuecomment-259001530, or mute the thread https://github.com/notifications/unsubscribe-auth/ADo1dGRYj2eCtppKn8w5hIH3r40xZxDbks5q77lDgaJpZM4Kn8fa .

delba commented 7 years ago

Thanks @jakerockland ! If it's okay, I would like to get back to you later because I'm still a bit confused though... Do you have an email?

Also, if you (@jakerockland, @AndrewSB) have an opinion on #35, I'd be really interested to hear it. I'm still undecided and I don't want to make a breaking change just after releasing the swift 3.0 version.

Thanks guys 😃

delba commented 7 years ago

I reverted the PR as there were still many issues with the bluetooth permission:

These issues have been fixed in https://github.com/delba/Permission/commit/f6b36cebcc72f2f99148b05cc813774d9a87972b

jakerockland commented 7 years ago

Hey @delba haven't got a chance to test this yet but I looked over your changes and they look good to me generally. I hadn't ran into those edge cases yet so I'm glad you caught them 😅 Definitely feel free to email me anytime though! jake@somaticlabs.io

jakerockland commented 7 years ago

Will be pulling the new v2.0 release and testing things out soon! 👍