fullfixed i hope - Githubissues

delcroip / dolibarr_project_timesheet

Timesheet view for project in Dolibarr

https://demo-timesheet.pmpd.eu

GNU Affero General Public License v3.0

34 stars 31 forks source link

fullfixed i hope #236

Closed tronx2100 closed 1 month ago

tronx2100 commented 1 year ago

i have made a fixed release which also fix the ios problem (iphone safari does not support text/javascript in php files). fixed stopwatch.js and a lot of more... added hamburger menu and make it more responsable Design. Fixed the translation to german.too.

Enjoy it! module_timesheet-4.6.7.zip_v17.txt

delcroip commented 1 year ago

thanks for this work

here my feedback

in temisheet.js: html += '<td colspan = "' + (headerLenth -1) + '" align = "right" > TOTAL </td>'; cannot be replaced by html += '<td></td><td align = "right" > TOTAL </td>'; because it needs to cover all colunm of the table, the nuber of column is base on config
the mobile support code (look advanced) is hardcoded in 2 pages I will try to inject it via function to avoid code duplication

I created a branch with your code, I will have to test it but I will try to do it next week to make a version out of it

delcroip commented 1 year ago

here the branch https://github.com/delcroip/dolibarr_project_timesheet/tree/issue/236

do hesitate to create branch your self and PR, even release, lately I am quite busy with other project so I am not so reactive

delcroip commented 1 year ago

Actually, to be fair it would be better if you create a branch like that your work will be under your name (I don't like "stealing" your code)