search

delcypher / freeboogie

Automatically exported from code.google.com/p/freeboogie
0 stars 1 forks source link

visiting methods should take one argument #32

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
It's convenient sometimes to have
  void see(
    VariableDecl vd,
    ImmutableList<Attribute> attr,
    String name,
    Type type,
    ImmutableList<AtomId> typeArgs,
    Expr where)
and then say
  name

instead of having
  void see(VariableDecl variableDecl)
and then say
  variabledecl.name()

BUT... the former is a *pain* to maintain when the abstract grammar
changes. Plus, the (necessary) vertical alignment of the arguments looks ugly.

This task is boring, takes time, but make further changes easier.

Original issue reported on code.google.com by radugrig...@gmail.com on 22 Aug 2009 at 10:40

GoogleCodeExporter commented 9 years ago

Original comment by radugrig...@gmail.com on 22 Aug 2009 at 10:41

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r596.

OK, I got tired of changing method signatures all over the place
when I change the abstract grammar. I'll switch to one-argument
visiting methods (which should be much more resilient to change)
now, before doing yet another change necessary for going to Boogie 2.

Original comment by radugrig...@gmail.com on 22 Aug 2009 at 10:46

GoogleCodeExporter commented 9 years ago 
Fixed a while back but I forgot to update the issue.

Original comment by radugrig...@gmail.com on 15 Sep 2009 at 3:54