search

delfer / docker-alpine-ftp-server

Small and flexible docker image with vsftpd server
189 stars 130 forks source link

Add group support and timezone support #41

Closed schmittse closed 2 years ago

schmittse commented 2 years ago

Hi,

I needed to specify a gid for the created user and the correct timezone inside the running container.

For the group part it's working and I didn't think of a better solution. For the TZ, I'm less sure. I found some information about a ENV TZ support in the Dockerfile but wasn't able to confirm so I go with the inside's alpine route and it's working. (official alpine doc : https://wiki.alpinelinux.org/wiki/Alpine_setup_scripts#setup-timezone)

Thanks a lot for your work.

delfer commented 2 years ago

@schmittse thank you for you PR! Can you please create a different PR for group support? About timezone, it can be easy solved by mapping two files from host OS into container:

volumes:
- /etc/timezone:/etc/timezone:ro
- /etc/localtime:/etc/localtime:ro

https://stackoverflow.com/questions/57607381/how-do-i-change-timezone-in-a-docker-container

schmittse commented 2 years ago

Hi,

Done for the new PR. For timezone, I'll check if it works for my needs, thanks.