Adopt Poetry as package manager and Makefile to hold scripts

delfick / alt-pytest-asyncio

An alternative plugin for pytest to make it support async tests and fixtures

https://alt-pytest-asyncio.readthedocs.io

MIT License

27 stars 5 forks source link

Adopt Poetry as package manager and Makefile to hold scripts #7

Closed andredias closed 3 years ago

andredias commented 3 years ago

I wonder if you are interested in adopting Poetry as the package management tool. It could also replace setup.py.

In addition, I'd also include a Makefile to store all development task scripts in one single file. I believe it would make the project simpler.

I contributed to another project recently with changes these: https://github.com/sabuhish/fastapi-mail/pull/89

delfick commented 3 years ago

Hello,

Thanks for the suggestion. I'm not a fan of poetry (tbf, haven't given it much of a chance) but I especially think for libraries, a setup.py is more appropriate.

Poetry tends to be more for applications than libraries.

And I also prefer separate scripts than a Makefile. Those tend to get quite messy and I almost never need more than the format, lint, test.sh trio I have in all my projects.

delfick commented 3 years ago

Also, sorry I was abrupt the other day. I was gonna ask if you wanted to make a change to functionality and then forgot. I imagine it was to play with the context vars?

andredias commented 3 years ago

No problem. This issue is not related to the other one #8