search

delfick / bespin

Opinionated wrapper around boto that reads yaml
MIT License
6 stars 8 forks source link

environment.account_id can be an integer #18

Closed atward closed 7 years ago

atward commented 7 years ago

As per existing documentation

delfick commented 7 years ago

hmm, I wonder why I did and_spec(string_spec, valid_string_spec), it should just need valid_string_spec, cause that uses string_spec when it's normalising.

As for the change itself, I don't see a problem with it.

I feel like there was a reason it's only a string, but I can't remember why, so I'll just merge it.

atward commented 7 years ago

it was actually or_spec(string_spec, valid_string_spec) which makes less sense.

delfick commented 7 years ago

yeah, true, it is a bit odd......

On Thu, 6 Apr 2017 at 14:13 Adam Ward notifications@github.com wrote:

it was actually or_spec(string_spec, valid_string_spec) which makes less sense.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/delfick/bespin/pull/18#issuecomment-292064259, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGq9RHe49989ZRgRHHetFz_cKz2GWAEks5rtGZ7gaJpZM4M1Fsk .