search

delfick / bespin

Opinionated wrapper around boto that reads yaml
MIT License
6 stars 8 forks source link

set termination protection as default to stacks #90

Closed danvela closed 6 years ago

delfick commented 6 years ago

Thanks for making a PR.

I'm all for supporting this option, but I'd rather it defaults to False and made configurable.

Also, I'd want the update operation to use boto3's update_termination_protection function if you change it's value in the configuration.

I'm sick atm (just a cold) so programming is a bit difficult, I'll take a look in a couple days when I can think properly again (unless you beat me to it!)

delfick commented 6 years ago

I've made https://github.com/delfick/bespin/commit/31f3a6de9a6f3ea3ed4b8713599bed98ae65ee45 an released version 0.7.3 to pypi.

There is now a termination_protection option. Just set it to True and your stack will get termination protection when it is created or updated.