Closed danvela closed 6 years ago
Hello,
I haven't had much chance to look at this today, should have time tomorrow.
Though I think I'd rather a sensitive_params
field in the configuration
that specifies what parameters shouldn't be echoed (maybe default to saying
"Password"). that way we're not introducing a cli parameter and allows
other sensitive fields to be censored.
On Tue, Nov 28, 2017, 6:57 PM danvela notifications@github.com wrote:
@delfick https://github.com/delfick this will allow bespin to hide/show password by adding --password-noecho option to command line
You can view, comment on, or merge this pull request online at:
https://github.com/delfick/bespin/pull/91 Commit Summary
- Update executor.py
- adding password options
- Update deployer.py
- Update bespin_obj.py
- Update bespin_obj.py
- Update bespin_specs.py
- Update netscaler.py
File Changes
- M bespin/executor.py https://github.com/delfick/bespin/pull/91/files#diff-0 (6)
- M bespin/operations/deployer.py https://github.com/delfick/bespin/pull/91/files#diff-1 (16)
- M bespin/option_spec/bespin_obj.py https://github.com/delfick/bespin/pull/91/files#diff-2 (2)
- M bespin/option_spec/bespin_specs.py https://github.com/delfick/bespin/pull/91/files#diff-3 (3)
- M bespin/option_spec/netscaler.py https://github.com/delfick/bespin/pull/91/files#diff-4 (3)
Patch Links:
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/delfick/bespin/pull/91, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGq9WhcAG_4vNlRHBH7KPiPck42R7auks5s67zugaJpZM4Qs0zC .
@delfick this will allow bespin to hide/show password by adding
--password-noecho
option to command line