Closed Djelibeybi closed 2 years ago
Nice :)
Though assignment operator is 3.8+ and photons in 3.7+ till June next year (when python stops making security updates for it).
But whether I be lazy and just make it 3.9+ wouldn't be hard to convince me of hahaha
On Thu, 23 June 2022, 5:42 pm Avi Miller, @.***> wrote:
@Djelibeybi https://github.com/Djelibeybi requested your review on: #111 https://github.com/delfick/photons/pull/111 control: add support for setting the direction of the MOVE effect.
— Reply to this email directly, view it on GitHub https://github.com/delfick/photons/pull/111#event-6863834817, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA2V5PJI6HIJXSFKTYSF33VQQIPJANCNFSM5ZTKUS6A . You are receiving this because your review was requested.Message ID: @.***>
But whether I be lazy and just make it 3.9+ wouldn't be hard to convince me of hahaha
Home Assistant is already 3.10+ which explains why I used the operator, I guess. But this is not significant enough a change to warrant a dependency bump, so I fixed it. :)
Oh, I love the fact that GitHub now lets you commit a suggestion by clicking a button. That's very handy.
GitHub's auto-merging is actually bad. Apologies. I'll pull and make the changes properly.
GitHub's auto-merging is actually bad. Apologies. I'll pull and make the changes properly.
hhahahah
Includes an update to the docs for both the task and Interactor command to provide a little more clarity on how to set this and other options.
Also updated the test for this effect.
Signed-off-by: Avi Miller me@dje.li