Closed Djelibeybi closed 4 months ago
Upstream have fixed the protocol specification so this is ready for review/merge.
@Djelibeybi are you able to clean up the commit history a little please ? :)
@Djelibeybi are you able to clean up the commit history a little please ? :)
I haven't squashed any of the commits, but I have cleaned up the commit messages. Hope that's what you meant. ;)
@Djelibeybi as in it feels this PR only really needs three commits
Done. I also switched the field names to snake case to match everything else and updated the help text just a little bit. :)
Looks good, thanks, do you want me to make a release too?
Not super urgent, but getting Interactor support would be nifty. I'm not sure if that's automagic these days or not.
I'm not sure if that's automagic these days or not.
not overly. Technically interactor only has a lower bound on photons, but the docker container needs to be rebuilt for home assistant
Anyway I have released new photons core and interactor and the docker builds here https://github.com/delfick/photons/actions/runs/9512926226
@Djelibeybi
I'll add a reminder to take the container for a spin over the weekend. I've spent enough time staring at a screen today. :)
~Note that the
TileEffectSkyType
enum is currently missing from the published protocol and needs to be added manually until LIFX add it themselves.~The
TileEffectSkyType
enum has been added upstream.Signed-off-by: Avi Miller me@dje.li