search

delfick / photons

Python3.6+ asyncio framework for interacting with LIFX devices
https://photons.delfick.com
MIT License
73 stars 6 forks source link

[packaging] adding a LICENSE to the packages on pypi #35

Closed delfick closed 3 years ago

delfick commented 3 years ago

Fixes #34

Anything else you need to make the rpm @Djelibeybi ?

Djelibeybi commented 3 years ago

I'll need to package https://github.com/delfick/delfick_project as well, so it's probably worth checking that it has a LICENSE file too. Besides that, I'll let you know as I get further along. I'm having to learn all the changes to Fedora's packaging guidelines (might as well do it proper) which is both fun and time-consuming.

Djelibeybi commented 3 years ago

I've just found another one: for some reason, the tarball on PyPi has a lifx_photons_core.egg-info directory (with underscores) but I can't determine why. It should be lidx-photons-core with hyphens to match the name of the package.

delfick commented 3 years ago

ok, I'll add it to delfick_project too. As for egg-info, it seems that's just what it does. Does it cause problems?

Djelibeybi commented 3 years ago

Nope. I've found another package that includes a hyphen and it's handled in the RPM specification file. [This particular] crisis averted! 😉

delfick commented 3 years ago

hehehhe, also, https://www.python.org/dev/peps/pep-0426/#name All comparisons of distribution names MUST be case insensitive, and MUST consider hyphens and underscores to be equivalent.

delfick commented 3 years ago

delfick_project 0.7.8 now has LICENSE in the pypi package. Next version of Photons will want it