search

delfick / photons

Python3.6+ asyncio framework for interacting with LIFX devices
https://photons.delfick.com
MIT License
73 stars 6 forks source link

Add options to effects/stop #64

Closed delfick closed 3 years ago

delfick commented 3 years ago

As pointed out in #61, Need to add to effects/stop options so you can pass things like power_on to the SetTileEffect and SetZonesEffect objects it uses

Djelibeybi commented 3 years ago

From what I can tell, power_on is about the only useful option for effects/stop? Would it not be easier just to add that as a boolean option?

Djelibeybi commented 3 years ago

Though, having a power_off option for effects/stop would be rather useful too, I reckon.

delfick commented 3 years ago

yeah, atm power_on is only useful one probably. But for consistency it's probs better to have matrix_options and linear_options for effects/stop too.

delfick commented 3 years ago

tests for now can probably just care about power_on.

We can add power_off as it's own separate option for sure, that'd be easy.

Djelibeybi commented 3 years ago

I just noticed that effects/stop can send an apply_theme and power_on is part of theme_options.

Kackerlacka commented 3 years ago

Hi, don't mean to revive the thread or anything but I figured this question would fit here best. It seems that when I run the effects/stop command with the following payload, my Tiles turn on very briefly and then back off again. My Candle, Beam, and Z Strip do not do this, but my Tiles do.

payload: '{"command": "effects/stop", "args": {"matcher": {"label": {{ label }} }, "stop_matrix": true, "matrix_options": {"power_on": false}, "stop_linear": true, "linear_options": {"power_on": false} }}'

Is part of the command written incorrectly to allow the Tiles to turn on when running effects/stop? Or is it something with Photons itself?

Djelibeybi commented 3 years ago

I recommend opening a new issue for this, as it'll get more attention.