search

delfick / photons

Python3.6+ asyncio framework for interacting with LIFX devices
https://photons.delfick.com
MIT License
73 stars 6 forks source link

fix: switches now have labels in device_finder_info #81

Closed Djelibeybi closed 2 years ago

Djelibeybi commented 2 years ago

The task was using GetColor to get the label, but that packet is not supported by the Switch so it had no label value. Changing to GetLabel solves this problem (at the expense of an additional packet).

Fixes #80.

Signed-off-by: Avi Miller me@dje.li

Djelibeybi commented 2 years ago

D'oh. I forgot to fix the tests. Will do so now.

delfick commented 2 years ago

Let's do it a bit differently anyway.

Make it so that only non lights get LABEL and lights still just get LIGHT_STATE.

Djelibeybi commented 2 years ago

Make it so that only non lights get LABEL and lights still just get COLOR.

Yep, that's what I'm doing. :) Will take me a bit longer, though. Need to add a switch to the tests too.