delfrrr / delaunator-cpp

A really fast C++ library for Delaunay triangulation of 2D points
MIT License
498 stars 98 forks source link

bug fixes and better testing #1

Closed morishuz closed 6 years ago

morishuz commented 6 years ago
delfrrr commented 6 years ago

Thank you for PR!

fixed bug with hashing. important: this changes the way the triangles get indexed relative to JS version. so in order to test i've generated new comparison data by modifying the JS version in the identical way.

Can you please submit the dataset which reproduces the bug with hashing?

delfrrr commented 6 years ago

@morishuz also, please fix path to test dir

https://github.com/delfrrr/delaunator-cpp/blob/6c587c061fcb97de3e38856ada5ae7c2aab50259/.travis.yml#L8

so CI can run correctly

morishuz commented 6 years ago

putting in new pull request that supersedes this one