search

delfrrr / npm-consider

Check package dependencies before installing it
Other
463 stars 15 forks source link

Incorrectly identifying UNLICENSED as public domain #18

Open Rycochet opened 5 years ago

Rycochet commented 5 years ago

Looks like it may be checking things in a specific order, so it's identifying it as "Unlicense" (which is a correct license).

https://docs.npmjs.com/files/package.json

Finally, if you do not wish to grant others the right to use a private or unpublished package under any terms: { "license": "UNLICENSED" }

I'd suggest doing a longest-fit search for the license, so it can get the correct category.

If someone puts the wrong license in their package.json then that is an issue for them to fix ;-)

brettz9 commented 4 years ago

This is pretty significant as it is completely the opposite. As with #24 , I think this could merit a whole new category since "Unlicensed" is not really "uncategorized" (though that would currently be the best fit); it is at least known to be forbidden for reuse. With "uncategorized", you know that there is a greater chance that you can contact the project owners to see whether they intended an open license.