delian / node-unifiapi

UniFi API ported to Node.JS
GNU General Public License v3.0
49 stars 19 forks source link

Still dependent on wrtc #14

Closed shankscoder closed 6 years ago

shankscoder commented 6 years ago

Looks like there are still parts that are looking for wrtc.

I just installed this library and tried to run the basic example in the docs. Using the latest version off of NPM (0.0.50) with Node v8.9.3.

Getting an Error: Cannot find module 'wrtc'.

This is the code I'm trying to run.

let unifi = require('node-unifiapi');
let r = unifi({
    baseUrl: url, // The URL of the Unifi Controller
    username: username
    password: password,
    site: site
    // debug: true, // More debug of the API (uses the debug module)
    // debugNet: true // Debug of the network requests (uses request module)
});
r.stat_sessions()
.then((data) => {
        console.log('Stat sessions', data);
        return r.stat_allusers();
})
.then((data) => {
        console.log('AP data', data);
})
.catch((err) => {
        console.log('Error', err);
})

I'd prefer to try and avoid web-rtc since I'm not planning to use any of those capabilities. Not sure why it's triggering the wrtc error.

delian commented 6 years ago

Let me check. May be there is one dependency that left inside

On Sat, 28 Apr 2018 at 12:29, Ashwin Shankar notifications@github.com wrote:

Looks like there are still parts that are looking for wrtc.

I just installed this library and tried to run the basic example in the docs. Using the latest version off of NPM (0.0.50) with Node v8.9.3.

Getting an Error: Cannot find module 'wrtc'.

This is the code I'm trying to run.

let unifi = require('node-unifiapi'); let r = unifi({ baseUrl: url, // The URL of the Unifi Controller username: username password: password, site: site // debug: true, // More debug of the API (uses the debug module) // debugNet: true // Debug of the network requests (uses request module) }); r.stat_sessions() .then((data) => { console.log('Stat sessions', data); return r.stat_allusers(); }) .then((data) => { console.log('AP data', data); }) .catch((err) => { console.log('Error', err); })

I'd prefer to try and avoid web-rtc since I'm not planning to use any of those capabilities. Not sure why it's triggering the wrtc error.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/delian/node-unifiapi/issues/14, or mute the thread https://github.com/notifications/unsubscribe-auth/AAG7Zo6rQdHTftfydUmWKUD7e3Y9PdV3ks5ttESkgaJpZM4TrWn9 .

--

Delian

delian commented 6 years ago

This happens due to the SSH module, as it also uses WRTC to implement the SSH access to the devices that support it. I will try to remove the dependency there but instead there will be a warning if you try to use the API and no wrtc module has been loaded

Delian

On Mon, Apr 30, 2018 at 8:56 PM Delian Delchev delian.delchev@gmail.com wrote:

Let me check. May be there is one dependency that left inside

On Sat, 28 Apr 2018 at 12:29, Ashwin Shankar notifications@github.com wrote:

Looks like there are still parts that are looking for wrtc.

I just installed this library and tried to run the basic example in the docs. Using the latest version off of NPM (0.0.50) with Node v8.9.3.

Getting an Error: Cannot find module 'wrtc'.

This is the code I'm trying to run.

let unifi = require('node-unifiapi'); let r = unifi({ baseUrl: url, // The URL of the Unifi Controller username: username password: password, site: site // debug: true, // More debug of the API (uses the debug module) // debugNet: true // Debug of the network requests (uses request module) }); r.stat_sessions() .then((data) => { console.log('Stat sessions', data); return r.stat_allusers(); }) .then((data) => { console.log('AP data', data); }) .catch((err) => { console.log('Error', err); })

I'd prefer to try and avoid web-rtc since I'm not planning to use any of those capabilities. Not sure why it's triggering the wrtc error.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/delian/node-unifiapi/issues/14, or mute the thread https://github.com/notifications/unsubscribe-auth/AAG7Zo6rQdHTftfydUmWKUD7e3Y9PdV3ks5ttESkgaJpZM4TrWn9 .

--

Delian

CornelSyrzysko commented 6 years ago

Good day,

Getting the same wrtc problem. Has it been sorted out yet?

Thank you.

Cornel Tomay

delian commented 6 years ago

Sorry, I forgot to commit. Can you please check again with version 0.51?

Delian

On Sat, May 12, 2018 at 1:46 PM CornelTolmay notifications@github.com wrote:

Good day,

Getting the same wrtc problem. Has it been sorted out yet?

Thank you.

Cornel Tomay

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/delian/node-unifiapi/issues/14#issuecomment-388549532, or mute the thread https://github.com/notifications/unsubscribe-auth/AAG7ZgBpHV5EBYnC2ohDJeByhir1WoeEks5txst-gaJpZM4TrWn9 .

CornelSyrzysko commented 6 years ago

Thank you. The wrtc problem is gone but there's a new error now: Error: Cannot find module 'pako'. Error is gone if I install wrtc. Never worked with pako before. Thank you for all the help.

delian commented 6 years ago

This is obviously a dependency that I forgot. The pako module is needed as Ubiquiti uses it to compress some messages. I've added the dependency and published a new version 0.52. Can you try it (please remove package-lock.* and node_modules before the test in order to have a correct test)

Delian

On Mon, May 14, 2018 at 3:21 PM CornelTolmay notifications@github.com wrote:

Thank you. The wrtc problem is gone but there's a new error now: Error: Cannot find module 'pako'. Error is gone if I install wrtc. Never worked with pako before. Thank you for all the help.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/delian/node-unifiapi/issues/14#issuecomment-388814028, or mute the thread https://github.com/notifications/unsubscribe-auth/AAG7Zj1Lnjbsm4XzESnZAkvmkUUH6i3Cks5tyYTbgaJpZM4TrWn9 .

CornelSyrzysko commented 6 years ago

Works good. Thanks for the help.

shankscoder commented 6 years ago

Works well now. Closing.