search

deliciousbrains / better-search-replace

A simple plugin for updating URLs or other text in a database.
https://bettersearchreplace.com
GNU General Public License v3.0
86 stars 36 forks source link

Selecting more tables #22

Closed stiffler17 closed 6 years ago

stiffler17 commented 9 years ago

I think there is a issue in the new version. When I select more tables with shift and click and execute it, the result show 1 table searched and not the quantity of selected tables.

Please check this.

mattgrshaw commented 9 years ago

Hi,

I'm not able to replicate this. Does it still show the correct number of changes (not tables)? Or are you getting any errors?

stiffler17 commented 9 years ago

No, there are no errors. I've selected all tables with shift and so on. If I look the details of the testrun it shows only the first table.
After the first pic I click execute. Afterwards it shows pic2. Pic3 is the detail view after the run. Few days ago the plugin works but since I updated it today this issue appers.

run1 run2 run3

GaryJones commented 6 years ago

FWIW, I'm not able to replicate this either. I select various combinations of tables with Shift, CMD, or CMD-A, and the table selection before and after the dry run is the same, and the modal shows the selected tables correctly as well.

BSR 1.3.1

ghost commented 6 years ago

@GaryJones Can replicate it here at a customer site, seems some hostings use different values for arg_separator.input and arg_separator.output which leads to a wrong value for bsr_data when it is created with http_build_query() default params by the plugin, more details in this thread.

GaryJones commented 6 years ago

@tkes Great summary and link - that should greatly help the team to get a fix in place :-)