deliciousbrains / wp-offload-ses-lite

WP Offload SES Lite sends all outgoing WordPress emails through Amazon Simple Email Service (SES) instead of the local wp_mail() function.
https://wordpress.org/plugins/wp-ses/
13 stars 11 forks source link

Checking value of `DISABLE_WP_CRON` before checking status of WP Cron #36

Open tjdownes opened 2 years ago

tjdownes commented 2 years ago

In QueueStatus check_status there's a check to see if WP Cron is working.

Many of us, for performance reasons or otherwise, disable WP Cron and use the system cron to execute these jobs. We still receive the warning. While not critical, it would be nice to see these warnings go away.

I'd create a PR for this, but there are some questions surrounding this. Primarily, this may create confusion for someone who inadvertently disable WP Cron.

We could simply check the value of DISABLE_WP_CRON and skip the notification in check_status, or maybe the alternative in the setup and settings is to let the user know that WP Cron is disabled and allow them to turn the warning on/off and carry that setting into the status check.

Anyone have thoughts on this?