Update dependencies and PHP version

rosswintle commented 2 years ago

This PR:

updates the dependencies (in particular Carbon v2) - resolves #12
updates the required PHP version to 7.3 (as required by Carbon v2.0 and PHPUnit v9.0)
adds WPCS and PHPStan
prepares for submission to packagist.org as deliciousbrains/wp-queue

All tests pass

There are some PHPCS and PHPStan fails that are not critical and will mostly need manual fixing.

Testing

A code review should show there's no functional changes. You can:

Run ./vendor/bin/phpunit
Run ./vendor/bin/phpstan analyze (there will be errors, but nothing that affects functionality)

rosswintle commented 2 years ago

@polevaultweb Do you want to review this wp-queue update? Or are you happy for one of the team to do it?

None of the code has changed. It's all dependencies, code formatting and some type hints.

I'll tag a v2.0 once we're happy (as I've bumped the minimum PHP version) and add to packagist as deliciousbrains/wp-queue.

This shouldn't break anything for anyone. The only possibility for users is dependency conflicts, which will be reported by composer.

polevaultweb commented 2 years ago

@rosswintle yes please get one of the team to review and test

rosswintle commented 2 years ago

@mauryaratan Can you take a look at this please? I'm trying to work through updating a bunch of dependencies for our sites and this is something we use.

deliciousbrains / wp-queue

Update dependencies and PHP version #18

Testing