search

deliciousbrains / wp-queue

Job queues for WordPress
MIT License
170 stars 38 forks source link

update min versions: carbon2 and php7.1.8 #7

Closed yipeecaiey closed 4 years ago

yipeecaiey commented 4 years ago

carbon1 is deprecated

NOTE: I have pulled in the changes from PR#5 into a seperate branch in my fork called develop. There was a merge conflict in composer.json. If you want to accept PR#5, I can create a separate pull request from the the develop branch.

yipeecaiey commented 4 years ago

Carbon2 requires min version of php 7.1.8. I have updated that in composer and all tests are passing in my environment. Checks are failing in Travis CI because of the build test configurations all using older versions of php (5.6, 7.0, and 7.1.27). Lmk if you don't want to support an upgraded version of php...or keep maintaining this package...and I'll see if it makes sense to just push this fork out as an independent package

yipeecaiey commented 4 years ago

And btw...I LOVE the concept of decoupling from wp_cron and implementing Laravelesque Jobs! Thanks for going there

polevaultweb commented 4 years ago

We can't bump the PHP version of the package to 7.x for now, as plugins that use it will still need to be compatible with WordPress' PHP minimum of 5.5.

I'll be looking at removing the dependency on Carbon in the future.