Error while trying example code from https://deno.land/x/view_engine

tinkajts commented 3 years ago

Getting this error while trying your example code: Executing with Deno ver 1.2 on windows 10:

deno run --reload --allow-net --allow-read fix.ts

error: TS2345 [ERROR]: Argument of type 'string | URL' is not assignable to parameter of type 'string'. Type 'URL' is not assignable to type 'string'. return new URL(url).pathname

    at https://deno.land/std@0.58.0/path/win32.ts:917:18

TS2345 [ERROR]: Argument of type 'string | URL' is not assignable to parameter of type 'string'.
  Type 'URL' is not assignable to type 'string'.
  return new URL(url).pathname;

at https://deno.land/std@0.58.0/path/posix.ts:438:18

Found 2 errors.

If i update to Oak ver 6.0.0 and drop the version 1.2.0 for the View-engine import, then the ctx.render function is missing, but then there's no issue with the url.

What to do?

tinkajts commented 3 years ago

if i use std@0.61.0 , but on some other code, then the issue with with

"error: TS2345 [ERROR]: Argument of type 'string | URL' is not assignable to parameter of type 'string'. Type 'URL' is not assignable to type 'string'. return new URL(url).pathname"

is gone.

gjuoun commented 3 years ago

view-engine v1.2 is supposed to work with oak@v5.3.1 and Deno < v1.20

https://github.com/deligenius/view-engine/releases/tag/v1.2.0

I'm going to release a new version soon

gjuoun commented 3 years ago

Please try view-engine v1.3, let me know if you still have issues.

https://github.com/deligenius/view-engine/releases/tag/v1.3.0

tinkajts commented 3 years ago

Thanks for the new version :)

No luck :( copy-pasted your example code.

Windows10 - deno 1.2.

Terminal output:

Last line translates to "The system can't find the path (os error 3)"

Later today i'll try on Ubuntu 20.04.

tinkajts commented 3 years ago

Hi again, works perfect on Ubuntu 20.04 with Deno 1.2.0. I noticed i didn't add --allow-read on the windows test. Will doublecheck with this flag tomorrow, but probably it will not work, since the deno server did not start on Windows at all, but did on Ubuntu without this flag. Got an error in the console when tied to access localhost:8000 without this --allow-read-flag on Ubuntu setup.

gjuoun commented 3 years ago

Sometimes I just used -A flag for testing purposes. You may try that, too.

tinkajts commented 3 years ago

Sadly, but no luck in Windows 10... Even with the -A. So i quess this is related to Deno compiler, not your code. So waiting it'll be.

gjuoun commented 3 years ago

Still no luck?

spedy commented 3 years ago

Looks like you are installing multiple versions of std lib.

The last function fromFileUrl doesn't check if url is instanceof URL.

Download https://deno.land/std@0.59.0/path/_constants.ts
Download https://deno.land/std@0.59.0/path/win32.ts
Download https://deno.land/std@0.59.0/path/posix.ts

The issue should be fixed in the latest versions.

gjuoun commented 3 years ago

Please use the newest version 1.4.0, denjucks is removed temporarily.

deligenius / view-engine

Error while trying example code from https://deno.land/x/view_engine #13