search

delight-im / Android-DDP

[UNMAINTAINED] Meteor's Distributed Data Protocol (DDP) for clients on Android
Apache License 2.0
274 stars 54 forks source link

Switch to GSON #131

Closed tomykho closed 7 years ago

tomykho commented 7 years ago

Is it possible to use GSON instead of Jackson?

ocram commented 7 years ago

Thanks for your feedback!

Is there any specific reason why this change should be implemented? Or is it just a personal preference?

tomykho commented 7 years ago

Yes, because APK grew bigger when using Jackson.

ocram commented 7 years ago

Thanks for explaining the motivation.

We might save up to 776.9 KB (uncompressed) if GSON was indeed a full replacement for everything that we currently use Jackson for. But since the binary size is not the only consideration, the space saved is not really that much (compressed even less) and replacing the implementation takes effort that might be more useful in other places, we won't do this for now. Sorry!