search

delight-im / Android-DDP

[UNMAINTAINED] Meteor's Distributed Data Protocol (DDP) for clients on Android
Apache License 2.0
274 stars 54 forks source link

Send data repeatedly #139

Closed PerkinsZhu closed 7 years ago

PerkinsZhu commented 7 years ago

when the socket is disconnet, the program will add the messages from client into mQueuedMessages ,when the socket is reconnected ,it will be resend to servers. but it don not removed from the mQueuedMessages .when the socket is disconnect again and reconnected again, the messages can be send again.So, the message must be remove from mQueuedMessages when it has be resend successful.

ocram commented 7 years ago

Thanks!

This is https://github.com/delight-im/Android-DDP/issues/61, by the way. I had proposed a solution there, already, but yours may be better.

Before we can merge this, we need two things:

  1. Can you run an example with the old version of this library (without your changes) and see if the messages are really sent multiple times? We need this to be reproduced in practice.
  2. Can you verify that the messages are not sent multiple times anymore after applying your changes? We need this to be tested in practice as well.
ocram commented 7 years ago

Merged in https://github.com/delight-im/Android-DDP/commit/fdf1ddc76302fb3c4d6998ab3c0c718fc6bd9a57.

Thanks again!