delight-im / Android-DDP

[UNMAINTAINED] Meteor's Distributed Data Protocol (DDP) for clients on Android
Apache License 2.0
274 stars 54 forks source link

Maven #34

Closed kordianbruck closed 8 years ago

kordianbruck commented 9 years ago

Would be awesome, if one could get the source code directly via maven.

Currently it is kinda messy to include the source code as a separate module in android studio.

ocram commented 9 years ago

Thank you!

I don't really think adding a JAR in Android Studio is that messy or difficult (anymore):

Regarding Maven, you're probably referring to this, right?

kordianbruck commented 9 years ago

Well yes, a JAR works fine, but if you want to publish your app open source, other people should be able to just download the source code and all dependencies will also be then downloaded automatically. I am not sure if this works with Autobahn in this project, but it make the usage way easier.

Check out this blog article for a proper explanation: http://inthecheesefactory.com/blog/how-to-upload-library-to-jcenter-maven-central-as-dependency/en

ocram commented 9 years ago

Thanks, I see your point.

I will look into this, but it may take some time. Sorry!

Leaving this issue open until it's done :)

jitpack-io commented 8 years ago

Hi

Would be very easy publish Android-DPP as a maven library on JitPack.io. All that's needed is a Gradle build file. Happy to submit a PR if you're interested. https://jitpack.io/#delight-im/Android-DDP

ocram commented 8 years ago

@jitpack-io Yes, please feel free to submit a pull request! This will allow us to judge if using your service is indeed more convenient while still fulfilling the requirements. Maybe it will solve the Maven issue for us :)

jitpack-io commented 8 years ago

Ok great, submitted PR #45. To publish a new version simply add a GitHub release. That's it:)

ocram commented 8 years ago

Can someone please try if you can include this library as a Maven dependency in Gradle now?

kordianbruck commented 8 years ago

@mwaclawek Yes - works like a charm! Thanks!

ocram commented 8 years ago

The README has been updated with the Gradle dependency information: https://github.com/delight-im/Android-DDP/blob/59e79b8e19c9ac74c7e428fa1bb4d50fc9b00b4a/README.md#installation

Thanks for testing, @kordianbruck, and thanks for providing this service, @jitpack-io!