Closed piejanssens closed 4 years ago
Excellent point, thank you!
This should have been fixed with this commit now.
Can you try? You’d need to update (to the next minor version) via Composer.
By the way, if you define \Delight\I18n\Codes::FR_BE
as supported, locale/fr_BE
is also where you put the files, not locale/fr
. It’s obvious that you had wanted to test this, of course. The change is that an fr
subdomain should now be mapped to \Delight\I18n\Codes::FR_BE
as well – unless \Delight\I18n\Codes::FR
is also explicitly supported.
Further, matching is case-insensitive, so you can safely use fr-be.example.com
in your URLs.
Works great, thanks! You might want to add this to the readme. You want to leave it open or close?
Thanks for testing this!
Documentation has now been added as well, so we can close this. Thanks again!
fr.example.com en.example.com
I can see that the language is correctly detected based on the subdomain, however putting the files in locale/fr or locale/fr_BE is not working to produce the translated webpage. Only when testing
fr-BE.example.com
the FR text shows.