search

delimitrou / DeathStarBench

Open-source benchmark suite for cloud microservices
Apache License 2.0
752 stars 419 forks source link

add jaeger metric preprocess #280

Closed Zhuofeng-Li closed 1 year ago

Zhuofeng-Li commented 1 year ago

I add jaeger metric preprocess and it's very easy. This will be helpful for users

Nick-LCY commented 6 months ago

@cdelimitrou I just realized that this piece of code originally came from our repository. It is unacceptable that there is no reference to our code.

https://github.com/Cloud-and-Distributed-Systems/Erms/blob/e6c347dff51758954f366552ffac2c03dcffbdf2/dataCollector/OfflineProfilingDataCollector.py#L165C4-L318

@Zhuofeng-Li Please create a new pull request, mentioning the source.

cdelimitrou commented 6 months ago

@Zhuofeng-Li please create a new pull request with correct attribution.

@Nick-LCY please keep in mind that this is a public project at this point and contributors are not necessarily affiliated with the original developer team.

Nick-LCY commented 6 months ago

@cdelimitrou Understood, I've communicated with @Zhuofeng-Li and he's created a new pull request #336 to submit a note about the source. Could you please merge it?