search

delip / PyTorchNLPBook

Code and data accompanying Natural Language Processing with PyTorch published by O'Reilly Media https://amzn.to/3JUgR2L
Apache License 2.0
1.98k stars 807 forks source link

where is early_stopping_criteria param in args set? #16

Open agi-templar opened 5 years ago

agi-templar commented 5 years ago

Hello,

I tried your sample code in Chapter 3 (CNN Classifier) and I found a line of code saying that:

  # Stop early ?
        train_state['stop_early'] = \
            train_state['early_stopping_step'] >= args.early_stopping_criteria

where args.early_stopping_criteria seems not being included in the args set.

joostware commented 5 years ago

This is something you might want to pass in as a command line parameter like --early-stopping-criteria

On Wed, Apr 24, 2019 at 7:36 PM Ruibo Liu notifications@github.com wrote:

Hello,

I tried your sample code in Chapter 3 (CNN Classifier) and I found a line of code saying that:

Stop early ?

    train_state['stop_early'] = \
        train_state['early_stopping_step'] >= args.early_stopping_criteria

where args.early_stopping_criteria seems not being included in the args set.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/joosthub/PyTorchNLPBook/issues/16, or mute the thread https://github.com/notifications/unsubscribe-auth/ACIVODXOZ7CII3U4JVVOON3PSEKLNANCNFSM4HIJITNA .

agi-templar commented 5 years ago

OK! Thank you for replying!