search

delishad21 / pe

0 stars 0 forks source link

Unable to add two people of the same name into the app #4

Open delishad21 opened 4 months ago

delishad21 commented 4 months ago

As mentioned in the user guide, "The user guide is mainly intended for secretaries of a large tech firm". In a large firm, there is a huge potential for people to have the exact same full name. This restriction prevents the user from adding both people into the application which is a huge inconvenience

nus-pe-script commented 4 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Mismatch of unique attributes for each contact

Given that "OH is a desktop app designed to assist secretaries of large tech firms in efficiently managing the contacts of the tech teams", it is more likely that some contacts will have duplicate names. Also, more often than not, not 2 contacts should have the same phone number of email address.

However, names are checked to be unique, and phone numbers and emails are not.

image.png

Hence, a mismatch between the product target users and its feature, as specified in "Features that don't fit well with the product".

[original: nus-cs2103-AY2324S2/pe-interim#200] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This can be an issue, but not important to the current implementation. This can be fixed in a future implementation.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** The group has stated under their product scope that the target user profile is a **Secretary of a tech company** that **has a need to manage a significant number of contacts** With a **significant number of contacts**, there is a high likelihood of duplicate names. Even in a local context, we have many people that share similar surnames (Lee, Tan) etc. Pair that with a common name like (John, Ryan etc.), it is highly probable that there may be two people with the exact same name working in the same tech firm. With this restriction of unique names placed on the application, the team has restricted the ability of their application to fulfill its intended purpose (i.e. managing a significant number of contacts). As such, I disagree that this issue is "not in scope". Based on the product scope the team has listed and the context in which the application is to be used, being able to add two people of the same name into the application should have been an important functionality that was implemented in the earliest iterations of the application, and not delayed to further iterations.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** As elaborated upon in the above explanation for the problem being in scope, the likelihood of duplicate names needing to be added to the application is high given the context in which the application is meant to be used. Meaning that the user would like have to suffer occasional inconveniences to find a way around this limitation. Making this issue a medium severity one.