search

deliveredtechnologies / rulebook

100% Java, Lambda Enabled, Lightweight Rules Engine with a Simple and Intuitive DSL
http://www.deliveredtechnologies.com
Apache License 2.0
717 stars 124 forks source link

Added Spring context awareness support in rulebook-spring module #134

Closed rizjoj closed 6 years ago

rizjoj commented 6 years ago

@Clayton7510 How does this look? Is the modification in AbstractRuleBookRunner acceptable? (I did it to avoid a lot of duplicate code in the subclass - so as to inherit any future changes from the superclass)

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.07%) to 94.161% when pulling 5ed62a02cf71630d2f58c3165cec36178265bab6 on rizjoj:feature/spring-context-aware-rulebook into e23cb4086aa78c4e6e40ea0941ae000d7469919c on rulebook-rules:develop.

rizjoj commented 6 years ago

@Clayton7510 How does it look now? I added javadocs to the getRuleInstance method to indicate that other containers can be used by their custom rule runners overriding this method. Any other suggestions/changes welcome - happy to comply.

Clayton7510 commented 6 years ago

Looks pretty good. I do think that some of the error handling logic in AbstractRuleBookRunner may be redundant - nothing of concern, tho. I may add some additional test to validate. But I really like the add and I appreciate the tests. Overall, this is a nice contribution. Thanks!

LukeHackett commented 6 years ago

Hi @Clayton7510, I really like this change. I was wondering when will this be released into the master branch? (I want to avoid using the snapshot version if possible)