search

deliveredtechnologies / rulebook

100% Java, Lambda Enabled, Lightweight Rules Engine with a Simple and Intuitive DSL
http://www.deliveredtechnologies.com
Apache License 2.0
716 stars 124 forks source link

184: Re-Throw UncheckedExecutionException #186

Closed jimmymain closed 3 years ago

jimmymain commented 4 years ago

Hi, I am happy to use a checked exception and re-throw all the way up the chain, but my feeling is that an unchecked exception is warranted here.

jimmymain commented 4 years ago

Hi, Are you happy that we use an unchecked exception here? If so I am very happy to increase the test coverage to have it pulled?

Clayton7510 commented 4 years ago

Sorry for the delay... pandemic and all. Work and personal life has been a little nuts. But now that it's settled to a consistent roar, time to catch up on RuleBook ;)

I'm OK with the unchecked exception. It was either that or hide the exception (what was currently being done) or change the method signature. Why did you use a 3rd party Exception class, tho?

Clayton7510 commented 3 years ago

Thanks for the contribution