deliverr / data-knex-snowflake-dialect

knex.js dialect for the Snowflake data warehouse
MIT License
13 stars 26 forks source link

Add support for multiple columns #8

Closed umairnadeem closed 4 years ago

umairnadeem commented 4 years ago

The following migration:

knex.schema.table('users', function (table) {
  table.string('first_name');
  table.string('last_name');
})

creates a query such as:

alter table "USERS" add "FIRST_NAME" varchar(255), **add** "LAST_NAME" varchar(255);

Whereas it should be:

alter table "USERS" add "FIRST_NAME" varchar(255), "LAST_NAME" varchar(255);
umairnadeem commented 4 years ago

Just realized we don't need this - it's already there for the mysql dialect.