search

dell / PyU4V

PyU4V is a Python module that simplifies interaction with the Unisphere for PowerMax REST API. It wraps REST calls with simple APIs that abstracts the HTTP request and response handling.
Apache License 2.0
41 stars 37 forks source link

feat: add possibility of configuring proxies #154

Closed arthurzenika closed 1 year ago

arthurzenika commented 1 year ago

closes #153

rawstorage commented 1 year ago

Thanks for this Contribution arthur, we will need to create a CI test for this pull request and run through our CI pipeline to make sure nothing gets broken before merge, I have some additional changes in the pipeline and will see if this can be merged into PyU4V 10.0 also. Do you need this fix at 9.2 or are you able to upgrade and use in 10.0.x version?

rawstorage commented 1 year ago

no this is fine, I can port if forward once I've had chance to run CI on it.

arthurzenika commented 1 year ago

Yes our use is on the 9.2 branch. I'm not sure I understand your comment about the CI, do you mean I should add a test ? or just that have to wait for the CI to run on your infrastructure ?

rawstorage commented 1 year ago

CI is our continuous integration, we run pytest with CI and Unit tests on all functions to make sure we don't break anything with additions and changing versions. I can add this before I test and do a release.

rawstorage commented 1 year ago

Arthur, this has been updated in 10.0.0.18, the 9.2 branch can not be updated, if possible can you update to version 10.x Unipshere version 10 will also be required.

arthurzenika commented 1 year ago

@rawstorage for my use case I cannot use the 10.x branch since I'm querying a 9.x vsphere installation. Any chance of having a bugfix release on the 9.2 branch ?

rawstorage commented 1 year ago

Arthur, I'll bring this one up with the team in the new year, it's technically not a bugfix but a feature request which we usually only bring to existing release. If you can pull into https://github.com/dell/PyU4V/tree/stable/9.2 branch I can try to get a release at this code, no promises yet..

In the meantime you can build the package using setup.py from your on branch and install with the .whl file, this may give you some relief until we can give a definitive answer on whether or not we can backport.

Paul Martin Senior Principal Engineering Technologist DellEMC | Enterprise Software and Storage - PowerMax and VMAX Cell +35387 696 0621 Timezone GMT

Follow me on Twitter @rawstorage Blog https://rawstorage.wordpress.com/

WhitePapers - https://infohub.delltechnologies.com/t/storage/

From: Arthur Lutz @.> Sent: 21 December 2022 13:10 To: dell/PyU4V @.> Cc: Martin, Paul @.>; Mention @.> Subject: Re: [dell/PyU4V] feat: add possibility of configuring proxies (PR #154)

[EXTERNAL EMAIL]

@rawstorage [github.com]https://urldefense.com/v3/__https:/github.com/rawstorage__;!!LpKI!gxWrf7oL8E4Q0Sjg5x6Z4051yCr-edQUaUdKV4s65wGvtxsTIH_6-PpN2cwhFMLVBIdJhGf147MUTAEMCySuGwjR$ for my use case I cannot use the 10.x branch since I'm querying a 9.x vsphere installation. Any chance of having a bugfix release on the 9.2 branch ?

- Reply to this email directly, view it on GitHub [github.com]https://urldefense.com/v3/__https:/github.com/dell/PyU4V/pull/154*issuecomment-1361294432__;Iw!!LpKI!gxWrf7oL8E4Q0Sjg5x6Z4051yCr-edQUaUdKV4s65wGvtxsTIH_6-PpN2cwhFMLVBIdJhGf147MUTAEMC3qFXVnF$, or unsubscribe [github.com]https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AF7FWPMWD7TIFKZHRW7EPVLWOL6S7ANCNFSM6AAAAAASDMU3VA__;!!LpKI!gxWrf7oL8E4Q0Sjg5x6Z4051yCr-edQUaUdKV4s65wGvtxsTIH_6-PpN2cwhFMLVBIdJhGf147MUTAEMCyNTXVnp$. You are receiving this because you were mentioned.Message ID: @.**@.>>

Internal Use - Confidential

arthurzenika commented 1 year ago

@rawstorage thanks for taking the time to look at this and pushing it to the team. Here is the PR : https://github.com/dell/PyU4V/pull/160