dell / ansible-powerflex

Ansible Modules for Dell PowerFlex
Other
22 stars 15 forks source link

Add support for fault sets to modules. #38

Closed ctronco closed 6 months ago

ctronco commented 7 months ago

Description

GitHub Issues

N/A

Checklist:

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration This code was is a backport of code that's been in use by my team, but this code was tested in a lab environment.

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 92.77899% with 66 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (main@7d9eeda). Click here to learn what that means.

Files Patch % Lines
...dule_utils/storage/dell/libraries/configuration.py 58.00% 18 Missing and 3 partials :warning:
plugins/modules/sds.py 91.17% 5 Missing and 13 partials :warning:
plugins/modules/info.py 68.75% 6 Missing and 4 partials :warning:
plugins/modules/fault_set.py 92.92% 4 Missing and 4 partials :warning:
...gins/module_utils/libraries/powerflex_unit_base.py 84.00% 2 Missing and 2 partials :warning:
...ule_utils/storage/dell/libraries/powerflex_base.py 82.35% 3 Missing :warning:
...s/unit/plugins/module_utils/libraries/fail_json.py 80.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #38 +/- ## ======================================= Coverage ? 82.80% ======================================= Files ? 46 Lines ? 5855 Branches ? 791 ======================================= Hits ? 4848 Misses ? 742 Partials ? 265 ``` | [Flag](https://app.codecov.io/gh/dell/ansible-powerflex/pull/38/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell) | Coverage Δ | | |---|---|---| | [units](https://app.codecov.io/gh/dell/ansible-powerflex/pull/38/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell) | `82.80% <92.77%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.