dell / ansible-powerflex

Ansible Modules for Dell PowerFlex
Other
22 stars 15 forks source link

[Module][Resource_Group] Add support for resource group provisioning #42

Closed Jennifer-John closed 5 months ago

Jennifer-John commented 6 months ago

Description

Add support for resource group provisioning to create, validate and delete a resource group deployment

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 89.86301% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 91.71%. Comparing base (ce855f1) to head (7ed44a5). Report is 12 commits behind head on main.

Files Patch % Lines
plugins/modules/resource_group.py 82.29% 15 Missing and 22 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #42 +/- ## ========================================== - Coverage 91.85% 91.71% -0.14% ========================================== Files 46 49 +3 Lines 6481 6870 +389 Branches 810 855 +45 ========================================== + Hits 5953 6301 +348 - Misses 297 316 +19 - Partials 231 253 +22 ``` | [Flag](https://app.codecov.io/gh/dell/ansible-powerflex/pull/42/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell) | Coverage Δ | | |---|---|---| | [units](https://app.codecov.io/gh/dell/ansible-powerflex/pull/42/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell) | `91.71% <89.86%> (-0.14%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ansible-collections-svc commented 6 months ago

Can one of the admins verify this patch?

Jennifer-John commented 6 months ago

run e2e

Jennifer-John commented 6 months ago

run e2e

felixs88 commented 5 months ago

Just please check if you can improve the missing lines coverage.

image In local report shows 93% for smiliar lines i will be checking...

Jennifer-John commented 5 months ago

run e2e