dell / ansible-powerflex

Ansible Modules for Dell PowerFlex
Other
22 stars 15 forks source link

[BUG]: Add Gateway port settings which is missing from some tasks #43

Closed coulof closed 4 months ago

coulof commented 5 months ago

Description

The port is not specify and therefore when customized it failed to install

If fixed and check for PowerFlex 3.x only

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

How Has This Been Tested?

Tested manually on my system

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.71%. Comparing base (ce855f1) to head (54da9ec). Report is 48 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #43 +/- ## ========================================== - Coverage 91.85% 91.71% -0.14% ========================================== Files 46 49 +3 Lines 6481 6871 +390 Branches 810 855 +45 ========================================== + Hits 5953 6302 +349 - Misses 297 316 +19 - Partials 231 253 +22 ``` | [Flag](https://app.codecov.io/gh/dell/ansible-powerflex/pull/43/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell) | Coverage Δ | | |---|---|---| | [units](https://app.codecov.io/gh/dell/ansible-powerflex/pull/43/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell) | `91.71% <ø> (-0.14%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ansible-collections-svc commented 5 months ago

Can one of the admins verify this patch?

coulof commented 4 months ago

Please fix the ansible lint issues associated with this PR.

Fixed

coulof commented 4 months ago

@sachin-apa

Isn't it already given in all the argument_spec.yml files ?

sachin-apa commented 4 months ago

@sachin-apa

Isn't it already given in all the argument_spec.yml files ?

@coulof Yes It is, but it doesn't mean that the value is defaulted, argument spec in role is used only for documentation and validation but the actual default value always comes from defaults/main.yml file. please refer here image

coulof commented 4 months ago

@sachin-apa, changed the defaults/main.yaml. Is it ok now ? Thx.

coulof commented 4 months ago

Closing without merge due to the linter issue.

The earlier commits were working and testing.

@Jennifer-John I let you decided what to do w.r.t. the configurable port for the API gateway.