dell / ansible-powerflex

Ansible Modules for Dell PowerFlex
Other
22 stars 15 forks source link

Adding support for Storage pool enhancements #57

Closed trisha-dell closed 3 months ago

trisha-dell commented 3 months ago

Description

Adding support for parameters for Storage pool.

Checklist:

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

ansible-collections-svc commented 3 months ago

Can one of the admins verify this patch?

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 68.47291% with 128 lines in your changes are missing coverage. Please review.

Project coverage is 90.36%. Comparing base (0df06dd) to head (c71e68b). Report is 24 commits behind head on main.

Files Patch % Lines
plugins/modules/storagepool.py 66.04% 90 Missing and 38 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #57 +/- ## ========================================== - Coverage 91.71% 90.36% -1.36% ========================================== Files 49 49 Lines 6871 7078 +207 Branches 855 919 +64 ========================================== + Hits 6302 6396 +94 - Misses 316 398 +82 - Partials 253 284 +31 ``` | [Flag](https://app.codecov.io/gh/dell/ansible-powerflex/pull/57/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell) | Coverage Δ | | |---|---|---| | [units](https://app.codecov.io/gh/dell/ansible-powerflex/pull/57/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell) | `90.36% <68.47%> (-1.36%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sachin-apa commented 3 months ago

run e2e