dell / ansible-powermax

Ansible Modules for Dell PowerMax
GNU General Public License v3.0
36 stars 37 forks source link

Fixes to support python3 and made initiators more flexible #1

Open coreywan opened 5 years ago

coreywan commented 5 years ago

On the dellemc_powermax_host module you used the cmp method. It is no longer available in Python3, and that is the default moving forward for Ansible.

If the input was a list of strings, I just used a quick comparison after conversion to sets to obtain the same result. For a complex dictionary, I found a function someone wrote and changed it to our use case of returning a bool value.

As an additional user usability feature, I created a method to get the user provided WWPN's that normalizes it to the input the VMAX is looking for. AKA strip out the colons, and force everything to lowercase. This makes it so we don't have to do that in Jinja outside of the module. Most OEM API's return the WWPN in all caps, and with the colon.