dell / ansible-powerscale

PowerScale (Isilon) Ansible modules
GNU General Public License v3.0
25 stars 21 forks source link

[FEATURE]: Unhide path when putting up error messages #74

Open pHiney opened 2 months ago

pHiney commented 2 months ago

Describe the solution you'd like I want this error message : "Invalid path ['****'], Path must start with '/'", to clearly and concisely show me the path. I cannot self correct if I can't see what information the tool got.

Describe alternatives you've considered no_log: false

I don't understand why it would be treated as a password

Additional context ansible stanza

- name: Add host to NFS share
  delegate_to: localhost
  no_log: false
  dellemc.powerscale.nfs:
    onefs_host: "{{onefs_host}}"
    port_no: "{{onefs_host_port}}"
    api_user: "{{api_user}}"
    api_password: "{{api_password}}"
    verify_ssl: "{{verify_ssl}}"
    path: "{{item}}"
    root_clients:
    - "{{ inventory_hostname }}"
    client_state: 'present-in-export'
    state: 'present'
  loop:
    - "{{ nfs_shares }}"

variable declaration

nfs_shares:
  - /ifs/test

Full error report

{
  "msg": "Invalid path ['********'], Path must start with '/'",
  "invocation": {
    "module_args": {
      "onefs_host": "isilon.dn",
      "port_no": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
      "api_user": "ansible",
      "api_password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
      "verify_ssl": false,
      "path": "['********']",
      "root_clients": [
        "server.dn"
      ],
      "client_state": "present-in-export",
      "state": "present",
      "access_zone": "System",
      "clients": null,
      "read_only_clients": null,
      "read_write_clients": null,
      "description": null,
      "read_only": null,
      "ignore_unresolvable_hosts": null,
      "sub_directories_mountable": null,
      "security_flavors": null,
      "map_root": null,
      "map_non_root": null
    }
  },
  "_ansible_no_log": false,
  "changed": false,
  "item": [
    "/ifs/test"
  ],
  "ansible_loop_var": "item",
  "_ansible_item_label": [
    "/ifs/test"
  ],
  "_ansible_delegated_vars": {
    "ansible_host": "localhost",
    "ansible_port": null,
    "ansible_user": "rexuser",
    "ansible_connection": "local"
  }
}
pHiney commented 2 months ago

Just for stamps, it works when hard coded. Just so folks don't get sidetracked by that issue.