dell / ansible-powerstore

Ansible Modules for Dell PowerStore
GNU General Public License v3.0
31 stars 24 forks source link

Adding Support for Service Configuration for appliances #40

Closed Bhavneet-Sharma closed 8 months ago

Bhavneet-Sharma commented 8 months ago

Description

Adding Support for Service Configuration for appliances using service_config module

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

codecov-commenter commented 8 months ago

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (61892f8) 88.69% compared to head (b2aca85) 88.68%. Report is 4 commits behind head on main.

Files Patch % Lines
...dule_utils/storage/dell/libraries/configuration.py 71.42% 5 Missing and 3 partials :warning:
plugins/modules/service_config.py 93.57% 2 Missing and 5 partials :warning:
...le_utils/storage/dell/libraries/powerstore_base.py 93.93% 0 Missing and 2 partials :warning:
...t/plugins/module_utils/mock_service_configs_api.py 93.75% 0 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #40 +/- ## ========================================== - Coverage 88.69% 88.68% -0.02% ========================================== Files 109 114 +5 Lines 14787 15038 +251 Branches 1759 1789 +30 ========================================== + Hits 13116 13337 +221 - Misses 1115 1127 +12 - Partials 556 574 +18 ``` | [Flag](https://app.codecov.io/gh/dell/ansible-powerstore/pull/40/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell) | Coverage Δ | | |---|---|---| | [units](https://app.codecov.io/gh/dell/ansible-powerstore/pull/40/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell) | `88.68% <93.92%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ansible-collections-svc commented 8 months ago

Can one of the admins verify this patch?