codecov[bot]
commented
1 year ago Codecov Report
Patch coverage: 77.01% and project coverage change: -0.20% :warning:
Comparison is base (
57095d3) 72.92% compared to head (b57da1f) 72.72%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #1031 +/- ## ========================================== - Coverage 72.92% 72.72% -0.20% ========================================== Files 62 63 +1 Lines 8266 8796 +530 ========================================== + Hits 6028 6397 +369 - Misses 1980 2111 +131 - Partials 258 288 +30 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `72.72% <77.01%> (-0.20%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/dell/csi-baremetal/pull/1031?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell) | Coverage Δ | | |---|---|---| | [...controllers/storagegroup/storagegroupcontroller.go](https://app.codecov.io/gh/dell/csi-baremetal/pull/1031?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell#diff-cGtnL2NyY29udHJvbGxlcnMvc3RvcmFnZWdyb3VwL3N0b3JhZ2Vncm91cGNvbnRyb2xsZXIuZ28=) | `68.40% <75.32%> (ø)` | | | [pkg/crcontrollers/drive/drivecontroller.go](https://app.codecov.io/gh/dell/csi-baremetal/pull/1031?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell#diff-cGtnL2NyY29udHJvbGxlcnMvZHJpdmUvZHJpdmVjb250cm9sbGVyLmdv) | `69.58% <90.00%> (+1.71%)` | :arrow_up: |:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Purpose
Resolves #1018
Refine Storage Group Feature: 1) Add StorageGroupStatus 2) If we perform drive removal on the drive selected by some storagegroup with numberDrivesPerNode>0, the storagegroup's reconcilation should be triggered and it can select another drive if applicable. 3) Block StorageGroupSpec Update 4) Add StorageGroupController UT 6) For the drive with existing volumes that matches the driveSelector of some storage group, the drive should be selected into its matching storage group when its exsiting volumes removed. 7) The blocked storagegroup deletion can continue instantly after all exisitng volumes on drives of this storage group is removed.
PR checklist
Testing
Manual test passed. Custom CI passed: https://asd-ecs-jenkins.isus.emc.com/job/csi-custom-ci/1559/ Custom Acceptance Passed: https://asd-ecs-jenkins.isus.emc.com/job/csi-custom-acceptance-tar_b_ona/36/