dell / csi-baremetal

Bare-metal CSI Driver
Apache License 2.0
72 stars 33 forks source link

[ISSUE-1045] Fake Attach Feature for Non-LVM-Block-Mode Volumes #1046

Closed CraneShiEMC closed 1 year ago

CraneShiEMC commented 1 year ago

Purpose

Resolves #1045

  1. Implement the fake attach feature for non-LVM-block-mode volumes.
  2. Temporarily remove the forbidden 3rd-party action script from our github PR validation workflow to fix our github PR validation startup failure.

PR checklist

Testing

We have manually verified that this fake attach solution for non-LVM-block-mode volumes can work both on HDD and NVME disks. custom-ci passed: https://asd-ecs-jenkins.isus.emc.com/job/csi-custom-ci/1561/ custom-acceptance on Atlantic passed: https://asd-ecs-jenkins.isus.emc.com/job/csi-custom-acceptance-tar_b_ona/38/ custom-acceptance on Openshift passed: https://asd-ecs-jenkins.isus.emc.com/job/csi-custom-acceptance-oil_bd/254/

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 73.65% and project coverage change: +0.04% :tada:

Comparison is base (8085a0a) 72.72% compared to head (35b29e7) 72.76%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1046 +/- ## ========================================== + Coverage 72.72% 72.76% +0.04% ========================================== Files 63 63 Lines 8796 8949 +153 ========================================== + Hits 6397 6512 +115 - Misses 2111 2147 +36 - Partials 288 290 +2 ``` | [Flag](https://app.codecov.io/gh/dell/csi-baremetal/pull/1046/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dell/csi-baremetal/pull/1046/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell) | `72.76% <73.65%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/dell/csi-baremetal/pull/1046?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell) | Coverage Δ | | |---|---|---| | [pkg/node/common\_test\_data.go](https://app.codecov.io/gh/dell/csi-baremetal/pull/1046?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell#diff-cGtnL25vZGUvY29tbW9uX3Rlc3RfZGF0YS5nbw==) | `100.00% <ø> (ø)` | | | [...kg/node/provisioners/utilwrappers/fs\_operations.go](https://app.codecov.io/gh/dell/csi-baremetal/pull/1046?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell#diff-cGtnL25vZGUvcHJvdmlzaW9uZXJzL3V0aWx3cmFwcGVycy9mc19vcGVyYXRpb25zLmdv) | `71.51% <0.00%> (-8.63%)` | :arrow_down: | | [pkg/node/volumemgr.go](https://app.codecov.io/gh/dell/csi-baremetal/pull/1046?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell#diff-cGtnL25vZGUvdm9sdW1lbWdyLmdv) | `74.44% <70.96%> (-0.23%)` | :arrow_down: | | [pkg/base/linuxutils/fs/fs\_helper.go](https://app.codecov.io/gh/dell/csi-baremetal/pull/1046?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell#diff-cGtnL2Jhc2UvbGludXh1dGlscy9mcy9mc19oZWxwZXIuZ28=) | `80.09% <83.01%> (+0.92%)` | :arrow_up: | | [pkg/node/node.go](https://app.codecov.io/gh/dell/csi-baremetal/pull/1046?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell#diff-cGtnL25vZGUvbm9kZS5nbw==) | `85.39% <100.00%> (+2.10%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

libzhang commented 1 year ago

do we need to update fake-attach.md in docs ?

CraneShiEMC commented 1 year ago

do we need to update fake-attach.md in docs ?

OK. I will update fake-attach.md accordingly before code merge.