dell / csi-baremetal

Bare-metal CSI Driver
Apache License 2.0
71 stars 34 forks source link

[ISSUE-1076] Race condition between volume reconstructor and volume d… #1077

Closed Andrzej-Zukowski closed 7 months ago

Andrzej-Zukowski commented 7 months ago

…iscovery

Purpose

Resolves #

Fix retries updateDrivesCRs procedure multiple times in case of apiserver being inaccessible. At the same time readiness status remains in false state blocking Volume Reconstruction phase

PR checklist

Testing

Provide test details

codecov[bot] commented 7 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (f45d675) 72.76% compared to head (b261900) 72.78%.

Files Patch % Lines
pkg/node/volumemgr.go 76.19% 3 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1077 +/- ## ========================================== + Coverage 72.76% 72.78% +0.01% ========================================== Files 63 63 Lines 8949 8969 +20 ========================================== + Hits 6512 6528 +16 - Misses 2147 2150 +3 - Partials 290 291 +1 ``` | [Flag](https://app.codecov.io/gh/dell/csi-baremetal/pull/1077/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dell/csi-baremetal/pull/1077/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell) | `72.78% <76.19%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.