dell / csi-baremetal

Bare-metal CSI Driver
Apache License 2.0
72 stars 33 forks source link

[Issue-1088] Drive status is not set to OFFLINE when health is changed to BAD #1089

Closed Kacper-Michon-DELL closed 8 months ago

Kacper-Michon-DELL commented 8 months ago

Purpose

Resolves #1088

Drive status is not set to OFFLINE when health is changed to BAD

PR checklist

Testing

Provide test details

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d5847f2) 72.84% compared to head (bbf0a7d) 72.87%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1089 +/- ## ========================================== + Coverage 72.84% 72.87% +0.02% ========================================== Files 63 63 Lines 8949 8957 +8 ========================================== + Hits 6519 6527 +8 Misses 2142 2142 Partials 288 288 ``` | [Flag](https://app.codecov.io/gh/dell/csi-baremetal/pull/1089/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dell/csi-baremetal/pull/1089/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell) | `72.87% <100.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mishoyama commented 8 months ago

@Kacper-Michon-DELL it shouldn't change to OFFLINE. Drive can have BAD health, but be ONLINE. ONLINE means it's detected by CSI