dell / csm

Dell Container Storage Modules (CSM)
Apache License 2.0
68 stars 15 forks source link

[FEATURE]: enable support for CSI driver installation with IPv6 #546

Open ddudzinski opened 1 year ago

ddudzinski commented 1 year ago

Describe the solution you'd like Enable validation for support IPv4 and IPv6 during CSI driver installation. I checked currently and we need update REGEX syntax as below: source: https://github.com/dell/csi-powerflex/blob/main/dell-csi-helm-installer/install-csi-vxflexos.sh

code changes should be done as below for section:

helper function to check IP validation

function check_ip() { IP=${1} REGEX="\b([0-9]{1,3}.){3}[0-9]{1,3}|([a-f0-9:]+:+)+[a-f0-9]+\b" ADDR=$(echo $IP | grep -oE ${REGEX}) RC=$? if [[ "$RC" -eq "0" ]]; then log smart_step "IP ADDR $ADDR format is ok" else log error "SDC MDM validation failed. IP address $ip format is not ok" fi }

Additional context currently during installation of CSI driver, I found as verification of IP is only for IPv4 and got below error: |- SDC MDM value created : ,

Error: SDC MDM validation failed. IP address format is not ok Installation cannot continue

After modification installation script: install-csi-vxflexos.sh with entries which I provided we able complete build with IPv6 and everything works correctly.

Verification Complete - Success

- Installing Driver - Get SDC config and make MDM string for multi array support - SDC MDM value created : , - IP ADDR format is ok - IP ADDR format is ok Success
--> Waiting for Deployment vxflexos-controller to be ready Success
--> Waiting for DaemonSet vxflexos-node to be ready Success

Operation complete

csmbot commented 1 year ago

@ddudzinski: Thank you for submitting this issue!

The issue is currently awaiting triage. Please make sure you have given us as much context as possible.

If the maintainers determine this is a relevant issue, they will remove the needs-triage label and assign an appropriate priority label.


We want your feedback! If you have any questions or suggestions regarding our contributing process/workflow, please reach out to us at karavi@dell.com.

shanmydell commented 1 year ago

@bharathsreekanth : Could you please have a look at this feature request?