search

dell / csm

Dell Container Storage Modules (CSM)
Apache License 2.0
70 stars 15 forks source link

[BUG]:Extra VolumeSnapshots were created with VolumeGroup Snapshot. #67

Closed phuongatemc closed 3 years ago

phuongatemc commented 3 years ago

Extra VolumeSnapshots were created with VolumeGroup Snapshot. We don't see this problem on all VolumeGroup Snapshots.

Steps to reproduce the behavior:

  1. Using dellemc/csi-volumegroup-snapshotter:v0.2.0 to create VolumeGroup Snapshot of 3 PVCs with same label "volume-group=volumeGroup1"

  2. Run VolumeGroup Snapshot: apiVersion: volumegroup.storage.dell.com/v1alpha2 kind: DellCsiVolumeGroupSnapshot metadata: name: "vg1-snap1" namespace: "helmtest-vxflexos" spec: driverName: "csi-vxflexos.dellemc.com" memberReclaimPolicy: "Delete" volumesnapshotclass: "vxflexos-snapclass" pvcLabel: "volumeGroup1"

  3. Get the result and found there are 6 VolumeSnapshot instead of 3. phuong@irv-vm-90-22 ~/work/vproxy-kubernetes (PPDM-159574-create-volumesnapshot) # k get dellcsivolumegroupsnapshots.volumegroup.storage.dell.com -n helmtest-vxflexos vg1-snap1 -o yaml apiVersion: volumegroup.storage.dell.com/v1alpha2 kind: DellCsiVolumeGroupSnapshot metadata: annotations: kubectl.kubernetes.io/last-applied-configuration: | {"apiVersion":"volumegroup.storage.dell.com/v1alpha2","kind":"DellCsiVolumeGroupSnapshot","metadata":{"annotations":{},"name":"vg1-snap1","namespace":"helmtest-vxflexos"},"spec":{"driverName":"csi-vxflexos.dellemc.com","memberReclaimPolicy":"Delete","pvcLabel":"volumeGroup1","volumesnapshotclass":"vxflexos-snapclass"}} creationTimestamp: "2021-10-07T21:28:43Z" finalizers:

    • vgFinalizer generation: 1 name: vg1-snap1 namespace: helmtest-vxflexos resourceVersion: "17321187" uid: b540018a-d032-4ed2-b808-27e43007d521 spec: driverName: csi-vxflexos.dellemc.com memberReclaimPolicy: Delete pvcLabel: volumeGroup1 volumesnapshotclass: vxflexos-snapclass status: creationTime: "2021-10-07T21:27:58Z" readyToUse: true snapshotGroupID: 217b52c106138b0f-c56b7c7b00000003 snapshotGroupName: vg1-snap1-100721-212844 snapshots: vg1-snap1-100721-212844-0-pvol1,vg1-snap1-100721-212844-1-pvol0,vg1-snap1-100721-212844-2-pvol2 status: Complete phuong@irv-vm-90-22 ~/work/vproxy-kubernetes (PPDM-159574-create-volumesnapshot) # k get volumesnapshot -n helmtest-vxflexosNAME READYTOUSE SOURCEPVC SOURCESNAPSHOTCONTENT RESTORESIZE SNAPSHOTCLASS SNAPSHOTCONTENT CREATIONTIME AGE vg1-snap1-100721-212843-0-pvol1 true snapcontent-0fa08d6e-62f8-44ef-860d-54d565da49fc 8Gi vxflexos-snapclass snapcontent-0fa08d6e-62f8-44ef-860d-54d565da49fc 56s 9s vg1-snap1-100721-212843-1-pvol0 true snapcontent-930aba6b-758b-4e66-9df1-c00a208d3b1e 8Gi vxflexos-snapclass snapcontent-930aba6b-758b-4e66-9df1-c00a208d3b1e 56s 9s vg1-snap1-100721-212843-2-pvol2 true snapcontent-57f03380-9715-40f5-a5de-25ec80f74a8e 8Gi vxflexos-snapclass snapcontent-57f03380-9715-40f5-a5de-25ec80f74a8e 56s 9s vg1-snap1-100721-212844-0-pvol1 true snapcontent-e5e9a2e0-caa7-4020-8a06-432ba4d27f60 8Gi vxflexos-snapclass snapcontent-e5e9a2e0-caa7-4020-8a06-432ba4d27f60 55s 9s vg1-snap1-100721-212844-1-pvol0 true snapcontent-61dc29f7-dddf-4c0a-9b0b-fb957188924d 8Gi vxflexos-snapclass snapcontent-61dc29f7-dddf-4c0a-9b0b-fb957188924d 55s 9s vg1-snap1-100721-212844-2-pvol2 true snapcontent-2ecfdd38-fa4a-4bb5-ab9e-0347b3b3fc78 8Gi vxflexos-snapclass snapcontent-2ecfdd38-fa4a-4bb5-ab9e-0347b3b3fc78 55s 9s phuong@irv-vm-90-22 ~/work/vproxy-kubernetes (PPDM-159574-create-volumesnapshot) #

Expected behavior Only 3 VolumeSnapshot should be created.

nb950 commented 3 years ago

please update to dellemc/csi-volumegroup-snapshotter:v0.3.0 , this has been fixed

jooseppi-luna commented 3 years ago

@phuongatemc when you get a chance, would you be able to update us on the status of this issue so we can address it or close it? Thanks!

phuongatemc commented 3 years ago

I no longer seeing this issue in version 0.3.0. Close this issue.