dell / dellemc-openmanage-ansible-modules

Dell OpenManage Ansible Modules
GNU General Public License v3.0
340 stars 164 forks source link

[FEATURE]: make `Post-process ISO image with isohybrid` and `Add correct checksum to iso` optional for when controller is building iso in Darwin #530

Open pixelsoccupied opened 1 year ago

pixelsoccupied commented 1 year ago

Describe the solution you'd like Hello, I have been using the role idrac_os_deployment to do some fresh installs. The control node in my case is a mac and there's no isohybrid and implantisomd5 for it.

I have successfully skipped those and the install of course completed without any issues.

Describe alternatives you've considered I looked for alternate libraries to achieve the task but nothing really came up.

Additional context Using mac to provision OSs may not the best way and I'm using this strictly for development purposes so I think ignoring tasks is safe.

I'm happy to provide a PR. In my case I added some default variables to in the main var file e.g

idrac_os_deployment_iso_enhance: true
idrac_os_deployment_iso_add_correct_checksum: true

But maybe using os_family in the when clause could be a nice way too.

...
    source:
      protocol: local
      iso_path: /Users/pixelsoccupied/redhat
      iso_name: rhel-9.2-x86_64-dvd.iso
    destination:
      protocol: http
      hostname: host-my-iso.com
      mountpoint: /var/www/html/os-ks
      iso_path: /os-ks
      iso_name: rhel-9.2-x86_64-dvd-ks.iso

Community Note