ABHISHEK-SINHA10 commented 1 year ago

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
Test Pull Request

COMPONENT NAME

OUTPUT

ADDITIONAL INFORMATION

Checklist:

[x] I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
[x] I have verified that new and existing unit tests pass locally with my changes
[x] I have not allowed coverage numbers to degenerate
[x] I have maintained at least 90% code coverage
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have maintained backward compatibility

ansible-collections-svc commented 1 year ago

Can one of the admins verify this patch?

ABHISHEK-SINHA10 commented 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Attention: 90 lines in your changes are missing coverage. Please review.

Comparison is base (9e78b6c) 80.76% compared to head (650e04b) 81.03%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## collections #567 +/- ## =============================================== + Coverage 80.76% 81.03% +0.26% =============================================== Files 189 191 +2 Lines 29409 30299 +890 Branches 4654 4777 +123 =============================================== + Hits 23752 24552 +800 - Misses 4999 5069 +70 - Partials 658 678 +20 ``` | [Flag](https://app.codecov.io/gh/dell/dellemc-openmanage-ansible-modules/pull/567/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell) | Coverage Δ | | |---|---|---| | [units](https://app.codecov.io/gh/dell/dellemc-openmanage-ansible-modules/pull/567/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell) | `81.00% <89.88%> (+0.26%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/dell/dellemc-openmanage-ansible-modules/pull/567?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell) | Coverage Δ | | |---|---|---| | [...t/plugins/modules/test\_idrac\_network\_attributes.py](https://app.codecov.io/gh/dell/dellemc-openmanage-ansible-modules/pull/567?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell#diff-dGVzdHMvdW5pdC9wbHVnaW5zL21vZHVsZXMvdGVzdF9pZHJhY19uZXR3b3JrX2F0dHJpYnV0ZXMucHk=) | `97.50% <97.50%> (ø)` | | | [plugins/modules/idrac\_network\_attributes.py](https://app.codecov.io/gh/dell/dellemc-openmanage-ansible-modules/pull/567?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell#diff-cGx1Z2lucy9tb2R1bGVzL2lkcmFjX25ldHdvcmtfYXR0cmlidXRlcy5weQ==) | `88.88% <88.88%> (ø)` | | | [plugins/module\_utils/utils.py](https://app.codecov.io/gh/dell/dellemc-openmanage-ansible-modules/pull/567?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell#diff-cGx1Z2lucy9tb2R1bGVfdXRpbHMvdXRpbHMucHk=) | `34.05% <22.22%> (-2.05%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ABHISHEK-SINHA10 commented 1 year ago

Sanity