dell / dellemc-openmanage-ansible-modules

Dell OpenManage Ansible Modules
GNU General Public License v3.0
340 stars 164 forks source link

[idrac_server_config_profile] Bugfix idrac server config profile 822 #568

Closed ShivamSh3 closed 1 year ago

ShivamSh3 commented 1 year ago

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

ISSUE TYPE

COMPONENT NAME
OUTPUT
ADDITIONAL INFORMATION

Checklist:

ansible-collections-svc commented 1 year ago

Can one of the admins verify this patch?

codecov-commenter commented 1 year ago

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (75012d6) 81.04% compared to head (48962b7) 82.45%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## collections #568 +/- ## =============================================== + Coverage 81.04% 82.45% +1.40% =============================================== Files 378 189 -189 Lines 58616 29208 -29408 Branches 9268 4629 -4639 =============================================== - Hits 47504 24082 -23422 + Misses 9796 4450 -5346 + Partials 1316 676 -640 ``` | [Flag](https://app.codecov.io/gh/dell/dellemc-openmanage-ansible-modules/pull/568/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell) | Coverage Δ | | |---|---|---| | [units](https://app.codecov.io/gh/dell/dellemc-openmanage-ansible-modules/pull/568/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell) | `82.42% <86.72%> (+1.40%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/dell/dellemc-openmanage-ansible-modules/pull/568?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell) | Coverage Δ | | |---|---|---| | [...lugins/modules/test\_idrac\_server\_config\_profile.py](https://app.codecov.io/gh/dell/dellemc-openmanage-ansible-modules/pull/568?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell#diff-dGVzdHMvdW5pdC9wbHVnaW5zL21vZHVsZXMvdGVzdF9pZHJhY19zZXJ2ZXJfY29uZmlnX3Byb2ZpbGUucHk=) | `94.66% <92.45%> (+89.62%)` | :arrow_up: | | [plugins/modules/idrac\_server\_config\_profile.py](https://app.codecov.io/gh/dell/dellemc-openmanage-ansible-modules/pull/568?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell#diff-cGx1Z2lucy9tb2R1bGVzL2lkcmFjX3NlcnZlcl9jb25maWdfcHJvZmlsZS5weQ==) | `88.28% <84.81%> (+75.58%)` | :arrow_up: | ... and [189 files with indirect coverage changes](https://app.codecov.io/gh/dell/dellemc-openmanage-ansible-modules/pull/568/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ShivamSh3 commented 1 year ago

All these changes are cherry picked on #566 PR.