rajshekarp87 commented 10 months ago

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
Test Pull Request

COMPONENT NAME

OUTPUT

ADDITIONAL INFORMATION

Checklist:

[x] I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
[x] I have verified that new and existing unit tests pass locally with my changes
[x] I have not allowed coverage numbers to degenerate
[x] I have maintained at least 90% code coverage
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have maintained backward compatibility

ansible-collections-svc commented 10 months ago

Can one of the admins verify this patch?

codecov-commenter commented 10 months ago

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (b95359c) 93.05% compared to head (7479e36) 93.10%. Report is 12 commits behind head on collections.

Files	Patch %	Lines
plugins/modules/idrac_license.py	90.90%	11 Missing and 19 partials :warning:
tests/unit/plugins/modules/test_idrac_license.py	98.83%	2 Missing and 3 partials :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## collections #602 +/- ## =============================================== + Coverage 93.05% 93.10% +0.05% =============================================== Files 191 193 +2 Lines 30574 31342 +768 Branches 4809 4885 +76 =============================================== + Hits 28450 29181 +731 - Misses 1304 1318 +14 - Partials 820 843 +23 ``` | [Flag](https://app.codecov.io/gh/dell/dellemc-openmanage-ansible-modules/pull/602/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell) | Coverage Δ | | |---|---|---| | [units](https://app.codecov.io/gh/dell/dellemc-openmanage-ansible-modules/pull/602/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell) | `93.10% <95.38%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Jennifer-John commented 9 months ago

@rajshekarp87 what about the UT's?

ABHISHEK-SINHA10 commented 9 months ago

@rajshekarp87 Add module in readme

dell / dellemc-openmanage-ansible-modules

[idrac_license]: License Import, export and delete #602