ABHISHEK-SINHA10 commented 8 months ago

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
Test Pull Request

COMPONENT NAME

OUTPUT

ADDITIONAL INFORMATION

Checklist:

[x] I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
[x] I have verified that new and existing unit tests pass locally with my changes
[x] I have not allowed coverage numbers to degenerate
[x] I have maintained at least 90% code coverage
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have maintained backward compatibility

ansible-collections-svc commented 8 months ago

Can one of the admins verify this patch?

codecov-commenter commented 8 months ago

Codecov Report

Attention: Patch coverage is 98.10066% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 93.43%. Comparing base (77868f7) to head (bb0d019).

Files	Patch %	Lines
plugins/modules/idrac_storage_volume.py	96.19%	5 Missing and 13 partials :warning:
.../unit/plugins/modules/test_idrac_storage_volume.py	99.65%	1 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## collections #630 +/- ## =============================================== + Coverage 93.26% 93.43% +0.17% =============================================== Files 195 197 +2 Lines 32302 33354 +1052 Branches 4973 5126 +153 =============================================== + Hits 30125 31164 +1039 + Misses 1332 1331 -1 - Partials 845 859 +14 ``` | [Flag](https://app.codecov.io/gh/dell/dellemc-openmanage-ansible-modules/pull/630/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell) | Coverage Δ | | |---|---|---| | [units](https://app.codecov.io/gh/dell/dellemc-openmanage-ansible-modules/pull/630/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell) | `93.43% <98.10%> (+0.17%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dell#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dell / dellemc-openmanage-ansible-modules

Feature: idrac_storage_volume #630